Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed resource arn if integration is deployed from govcloud [CDS-1667] #184

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

guyrenny
Copy link
Contributor

@guyrenny guyrenny commented Nov 7, 2024

Description

Add new variable govcloud_deployment to enable in case that the integration is being deploy from govcloud, if enable arn for resource in the template will use arn:aws-us-gov instead of arn:aws.
Add condition for the aws_iam_policy.AWSLambdaMSKExecutionRole resource so it will only create it in case that msk is enabled

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the relevant example in the examples directory for the module.
  • I have updated the relevant test file for the module.
  • This change does not affect module (e.g. it's readme file change)

@guyrenny guyrenny requested a review from a team as a code owner November 7, 2024 14:18
Copy link
Contributor

@juan-coralogix juan-coralogix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guyrenny guyrenny merged commit 575ba07 into master Nov 10, 2024
6 checks passed
@guyrenny guyrenny deleted the govcloud-bug-fix branch November 10, 2024 10:11
Copy link

🎉 This PR is included in version 2.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants